Skip to content
OverviewSolutions
9
Comments
11

Tomazi

@tomazi15300 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • Tomazi•300
    @tomazi15

    dont think you can import svg's using css in React, you can import svg as a component: there are some examplese here good read:

    https://www.freecodecamp.org/news/how-to-import-svgs-in-react-and-vite/

    Marked as helpful
  • Tomazi•300
    @tomazi15

    @Corbinhol

    Really good functionality and design, I would break it up into components it would be easier to maintain and manage.

    A very good practice is to always add form validation because at the moment the user can enter anything, ie invalid email, name or pone number, You could start with something very simple that html gives you out of the box in you email input can be set to type="email" or phone number to type="number" this would make sure that the user is forced to enter valid email and for phone user has to enter numbers only, also the form can be submitted without entering any data

    Just few things to consider but overall well done and keep it up

  • Tomazi•300
    @tomazi15

    Hi @Alpha437

    Congrats on completing your challenge it looks really good, there might be some heights and widths but without figma guidelines its hard to get it 100% but considering think your solutions looks great.

    In terms of responsiveness as a good practice use mobile-first design methodology.

  • Tomazi•300
    @tomazi15

    Hi @Taiwo-art

    Sometimes i also find that some colours provided for the challenges do not really match the prototype.

    When that happens i usually find the solution for the challenge i am working on and use chrome colour picker extension to get the correct colours.

    Marked as helpful
  • Tomazi•300
    @tomazi15

    Hi @Kamil Wiater

    Firstly i think you have done great job in terms of the design and responsiveness.

    One thing i would change immediately is the directory naming convention ie: secondary page when you have a folder with a space in it i can cause you a lot of headache if you were trying to ship your code into production, when you bundle your code it could break. to avoid it just try sticking to not using space ie: secondaryPage.

    Next thing i would do i would strip the html page from its sections and turn them into stand alone components.

    also i would create src directory when i would keep all the implementation files to keep them away from all the config files like package.json

    suggested file structure:

    ./src/ components/ pages/ images/

    Also for each component, you would create a sub directory where you would keep all the component specific file ie: component.js componet.scss component.test

    Keep the up the good work 👌

    Marked as helpful
  • Tomazi•300
    @tomazi15

    Hi @Divyanshu Sharma

    When you want to host your static project on github it has to have index.html this is the standerd naming convention otherwise github will not display. change Learn.html to index.html

View more comments