Skip to content
OverviewSolutions
10
Comments
9
Vinh Le
@vinhle-dev

All comments

  • WB52•190
    @WB52
    What are you most proud of, and what would you do differently next time?

    I enjoyed working with Javascript more and learn more with every challenge I complete.

    What challenges did you encounter, and how did you overcome them?

    Had some trouble with the input invalidation part of the input and the error state, as in changing the changing colours of input field and adding the “Valid email required” text when non valid text is entered. With some research I discovered some Pseudo-classes that were new to me and could do this through CSS.

    Still not sure if it should show an error state when the page first loads? but it works and when disappears when typing starts in the input field.

    What specific areas of your project would you like help with?

    Any feedback and pointers welcome, thanks...

    Newsletter sign-up with success message

    1
    Vinh Le•180
    @vinhle-dev

    Wow, your site looks almost perfect and suitable for the design. But it seems that email validator always returns an invalid message. I think the error should only be displayed when the user clicks the send button.Read the previous lesson of this challenge on "Managing forms with JavaScript" for more details.

    Happy coding!

  • Vinh Le•180
    @vinhle-dev

    You should use JS to interact with the CSS classes instead of changing the style of the style attribute It seems that your design in mobile devices is missing the shared button when the sharing button is activated.

    Happy coding!

    Marked as helpful
  • Vinh Le•180
    @vinhle-dev

    It's look great

  • P
    Ivo•170
    @ijerkov
    What are you most proud of, and what would you do differently next time?

    Next time I would refresh my grid knowledge before coding.

    What challenges did you encounter, and how did you overcome them?

    Layout was a challenge at first, I overcame it by spending a couple of hours repeating the grid basics.

    Four card feature section, plain CSS

    1
    Vinh Le•180
    @vinhle-dev

    Wow, it looks great

  • Vinh Le•180
    @vinhle-dev

    It looks great. But it seems that you have used the wrong font for the product description.

  • Diana Codaus•230
    @DyaC-703
    What are you most proud of, and what would you do differently next time?

    I'm most proud of how I managed to complete the project while learning new tools and improving my problem-solving skills.

    Next time, I would focus on planning the structure of the project more thoroughly before starting to code.

    What challenges did you encounter, and how did you overcome them?

    One of the main challenges I encountered was setting up GitHub Pages for the project. At first, the site wasn't displaying correctly. I overcame this by carefully checking the file structure, making sure all paths were correct, and ensuring that all files were uploaded properly. I also researched solutions online and tested different approaches until it worked.

    What specific areas of your project would you like help with?

    I would appreciate help with optimizing the performance of my website, particularly with image loading times and improving responsiveness on mobile devices.

    Recepie Project

    1
    Vinh Le•180
    @vinhle-dev

    Your solution looks great everything is aligned in the middle. But it seems that it is not entirely the same as the original design that the challenge offers. You should be more concerned and sticking to the designs that have been given as fonts, colors, and how to lay the elements. It is part of our work.

  • Vinh Le•180
    @vinhle-dev

    Your solution looks great

  • Muhammad Pauzi•60
    @4glightning
    What are you most proud of, and what would you do differently next time?

    I managed to design the website exactly to the design given and the next thing that i would try differently is that using other method like javascript for dynamic font resizing.

    What challenges did you encounter, and how did you overcome them?

    looking for other method to resize the font to make it responsive in each screen sizes. I used the github copilot to help me find other method available and it is really helpful and i also learn so much other method available to make the font to be responsive.

    What specific areas of your project would you like help with?

    How do pick the correct font sizes or family for my website? is there a tips on how to set the perfect font size or family to your website to make it more user friendly or make it readable.

    I used flexbox to center the card and also used rem for font sizes.

    2
    Vinh Le•180
    @vinhle-dev

    You are missing the border of the card. The color of the card content is not in accordance with the design You can try to use Figma from challenges to be able to get the exact figures of the design.

    Marked as helpful
  • Vinh Le•180
    @vinhle-dev

    You have a missing padding for the title and text content