Yong Zhi• 110
@pohyongzhi
Submitted
I would like to know if my code is well-structured and according to the standard conventions.
Thank you in advance!
P
Waldemar Glaz
@waldekglaz
All comments
- PWaldemar Glaz• 775
@waldekglaz
Posted
hey @pohyongzhi
Try to fix "jumping" effect when hover over learn more buttons.
Good job
Marked as helpful
1 - xsuma12• 210
@Xjanus12x
Submitted
I would greatly appreciate your feedback on my project so that I can make improvements. Thank you in advance for taking the time to share your thoughts with me.
PWaldemar Glaz• 775@waldekglaz
Posted
Hi
It looks good.
You could use
type="tel"for Phone Number field and add some validation to make it perfect.Marked as helpful
1 - JLB24• 450
@Jlbspyder
Submitted
I'm struggling with making this responsive... Any kinda help would be appreciated
PWaldemar Glaz• 775@waldekglaz
Posted
Hi You can check my solution to see how I tackled styling. I used Tailwind CSS. My solution
0 - Konstantin Christ• 450
@Konstantinchrist
Submitted
Hello guys, I hope you're doing great. Here is my project of today. I just had one issue: The eye (when you hover on the nft-image) has the opacity of the background div there. How do I fix this? If you find other issues please let me know. I appreciate your support :).
Hugs from the potato country Konstantin
PWaldemar Glaz• 775@waldekglaz
Posted
Hi Konstantin
Instead of
.background:hover{ opacity: .4; }Try setting background-color to rgba with opacity value, then your svg will have opacity: 1 and background will be semi transparent.I hope it helps.
Cheers
Marked as helpful
0 - Sheldon Fam• 160
@SheldonFam
Submitted
Hi guys,
Any advise or feedback to improve my coding is high appreciated.
Thank you and Happy Coding!😀
PWaldemar Glaz• 775@waldekglaz
Posted
Hi Sheldon,
Very nice work, I am on it at the moment as well. I went different way and instead of using Router I just went with conditional rendering.
I've noticed two things: 1.that some of the flags are cropped, because of the different size of the images ( I used fixed height of images to sort it out) 2. In the detail page try to get Border Countries full names based on country code. (I've spent some time to figure it out 😊 )
I hope you will check my solution when ready (should finish it tomorrow) and give me some advice too.
Have a good day
@waldekglaz
0 - Ophélie Coudert• 50
@Crab-Prog
Submitted
Hello, I'd love to know how do you find the exact dimension of the card ? Because I try to do what I see on the design files, but I usually mistaken some widths and heights 🤔
Thank you !
PWaldemar Glaz• 775@waldekglaz
Posted
Hi Ophelie Dimensions are available in figma / sketch files if you hold pro account On mobile try width 343px and 540px on desktop
0 - vinaykotturi• 70
@vinaykotturi
Submitted
I used a button tag instead of a tag in this challenge is this acceptable?
- your feedback is very valuable to me.
PWaldemar Glaz• 775@waldekglaz
Posted
Hi, I just finished the same challenge and I used <a> instead of <button> and I think you did good job and I need to change mine.
1
