@kingomer02
Suman Das
@webdevsumanAll comments
- @webdevsuman
Button font weight should be more. 900 should be alright.
- @Dhiman-Chandra-Ray@webdevsuman
Colours don't match and the line-through colour should be same as paragraph. Size don't match. This requires more effort.
- @nadam-designWhat are you most proud of, and what would you do differently next time?
I tried mx best to structure the page that follows the design as close as possible. The devil is in the details. I used tags, not sure if it's correct here.
What challenges did you encounter, and how did you overcome them?The most challenging part was ensuring that the image is 100% wide on mobile, while it has padding around on tablet and desktop. I might have overthought it a bit, so I ended up choosing what I believe is the simplest solution: I applied the padding to the two child elements of the recipe element. Could there be a simpler or better solution?
@webdevsumanYou seem to complicate the work. The simplest solution is to give the image-div some negative margin.
Marked as helpful - @Jenishkubavat@webdevsuman
Good. The size of the component should be a little bigger. Buttons border colour is not looking nice. The quote should have a light color opposite to the dark background. The alignments are very good.
- @guillaume-pagesWhat are you most proud of, and what would you do differently next time?
Nothing to say
What challenges did you encounter, and how did you overcome them?Nothing to say
What specific areas of your project would you like help with?Nothing to say
@webdevsumanLooks good. But the avatar image link is not working it seems. Try with "./assets/images/image-avatar.webp".
For responsive view in Mobile device even in landscape, Add media query and set the main section height to auto. 100vh is good for large screens but crops the design in mobile device when landscaped. Also, it is a good practice to use external css file for "separation of concern".
Marked as helpful - @khal45@webdevsuman
Try to make it responsive below 1025px.
