Resulting JavaScript code seems too large. Can it be done with less code?
This was my first time incorporating typescript into a project
What challenges did you encounter, and how did you overcome them?Using the right types majorly
What specific areas of your project would you like help with?I would like a review of my index.ts file. I would appreciate any feedback on it
Hey, nice work on your project! I really like how you've structured the app, and it's clear you put a lot of effort into it. The layout looks decent and follows the design pretty well, so great job on that!
But I notice a few areas that could be improved. First, the strength indicator depends only on checkbox selection, not on the character length, which feels off. Ideally, it should also consider the password length for a more accurate assessment, maybe combine the number of character types with length for a better strength score.
Second, when a checkbox is ticked, the strength block increases in height, which shouldn’t happen, it should maintain a consistent size regardless of selection.
Third, when hovering over checkboxes, they don’t change color, which could improve interactivity. Adding a hover effect (e.g., changing a border color like in design) would make them more engaging.
Fourth, when hovering over the "Generate" button, the cursor doesn’t change to a pointer, which is a small but useful detail to indicate it's clickable.
Overall, it's a solid effort, just needs these tweaks to polish it up. Thanks for sharing, and good luck with your projects!
Hey, nice work on your Frontend Mentor project! I really like how you put everything together, it's clear you worked hard on this. The page looks good and feels close to the design, so good job on that! But I notice some things that can be better. First, the style is almost like the design, but not exactly — input fields are a bit wider than they should be, and it makes them look not as nice as in the original. Maybe making them smaller will match better. Second, when I check on smaller screen, the 'Custom' word in the custom percent input is not in the center — it moves to the right side of the form, which looks a little off. Third, the forms let you type unlimited characters. It's not a must, but I think it's good idea to limit it to just numbers and maybe not so many characters, so it feels more controlled. Fourth, the Reset button doesn’t work how I expect — after I click Reset and then type in Bill, the Tip amount and Total show up even if I didn’t pick a tip percent or number of people yet. It should probably stay at zero until everything is filled. Last, when Bill, percent, and number of people are selected, clicking other percent buttons doesn't update the Tip amount and Total amount. This is confusing because those numbers should change with the new percent, but they stay the same. Users might not understand what's happening there. Overall, it's a solid work, just needs some fixes to make it perfect. Thanks for sharing, and good luck with it!
Well done. All functionality is implemented, HTML is semantic, everything looks accessible, and layout looks good on a range of screen sizes. The code looks well-structured, readable, and reusable. Solution is almost identical to the design, the only difference I could spot is that the avatar on the page needs to have white border. Other than that, everything looks great. Thanks and good luck!
This time, I took a slightly different approach to building the base layout by using absolute positioning instead of CSS Flexbox. Additionally, I implemented basic validation for the email input field. While the solution is quite simple, it functions as intended and maintains a similar appearance.
What challenges did you encounter, and how did you overcome them?The most challenging part this time wasn’t the JavaScript functionality or form validation but rather styling the images and SVGs.
I like your solution, especially CSS and how smooth the page changes depending on the screen size. In general, everything looks how it has to be, except for one small issue, when the email is entered and submit, on the Subscribed confirmation screen, it should probably show the email that the user entered instead of the default email "ash@loremcompany.com". Other than that, everything is good. Thanks and have a good day!
All feedback is welcome!
The solution includes semantic HTML and is accessible. The layout looks good on a range of screen sizes, the code is well-structured, readable, and reusable. The solution matches the design.
Solution includes semantic HTML, it is accessible and layout looks good on a range of screen sizes. Code looks well-structured, readable, and reusable. The solution does not differ considerably from the design.
