@Adecom16
Submitted
Yash Joshi
@yashgjoshi20
All comments
- Yash Joshi• 450
@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should add an <main> tag after body and before the div tags.
- Instead of using <div class="container">, you should use <main class="container">
- The <main> tag specifies the main content of a document.
- You should put the <div class="attribution"> outside the <main> tag
- Then replace the <div> tag by semantic tag <footer>
- footer can contain information about author, copyright etc.
HTML
<body> <main class="container"> <div> </div> </main> <footer class="attribution"> .... </footer> </body>I hope you'll find this helpful, and your solutions is really good. 😌
0 - Yash• 160
@Yash1Hingu
Submitted
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should add an <main> tag after body and before the div tags.
- Instead of using <div class="container">, you should use <main class="container">
- The <main> tag specifies the main content of a document.
- You should put the <div class="attribution"> outside the <main> tag
- Then replace the <div> tag by semantic tag <footer>
- footer can contain information about author, copyright etc.
HTML
<body> <main class="container"> <div> </div> </main> <footer class="attribution"> .... </footer> </body>I hope you'll find this helpful, and your solutions is really good. 😌
Marked as helpful
0 - AnakonStar• 40
@AnakonStar
Submitted
I would like to know if my code is good enough to be hired, like, the correct use of tags and the way I positioned them.
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should add an <main> tag after body and before the div tags.
- The <main> tag specifies the main content of a document.
- You should put the <div class="attribution"> outside the <main> tag
- Then replace the <div> tag by semantic tag <footer>
- footer can contain informations about author, copyright etc.
HTML
<body> <main> .... </main> <footer class="attribution"> </footer> </body>I hope you'll find this helpful, and your solutions is really good. 😌
Marked as helpful
1 - TimCauss• 10
@TimCauss
Submitted
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should add an <main> tag after body and before the div tags.
- The <main> tag specifies the main content of a document.
- You should put the <div class="attribution"> outside the <main> tag
- Then replace the <div> tag by semantic tag <footer>
- footer can contain informations about author, copyright etc.
HTML
<body> <main> .... </main> <footer class="attribution"> </footer> </body>I hope you'll find this helpful, and your solutions is really good. 😌
Marked as helpful
1 - Souhail• 40
@souhailsenini
Submitted
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should add an <main> tag after body and before the div tags.
- The <main> tag specifies the main content of a document.
- You should put the <div class="attribution"> outside the <main> tag
- Then replace the <div> tag by semantic tag <footer>
- footer can contain informations about author, copyright etc.
HTML
<body> <main> .... </main> <footer class="attribution"> </footer> </body>I hope you'll find this helpful, and your solutions is really good. 😌
Marked as helpful
1 - m0nagamal• 90
@m0nagamal
Submitted
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should add an <main> tag after body and before the div tags.
- The <main> tag specifies the main content of a document.
- You should put the <div class="attribution"> outside the <main> tag
- Then replace the <div> tag by semantic tag <footer>
- footer can contain informations about author, copyright etc.
HTML
<body> <main> .... </main> <footer class="attribution"> </footer> </body>I hope you'll find this helpful, and your solutions is really good. 😌
0 - Ahmed Gamal• 10
@stackj007
Submitted
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completing this challenge😁
I have some suggestions to help you to improve your solution :
- You should replace the <div class="footer"> to <footer class="footer".
- footer can contain information about author, copyright etc.
<body> <footer class="footer"> </footer> </body>I hope you'll find this helpful, and your solutions is really good. 😌
0 - Dellenar• 160
@dellenar
Submitted
Hello There,
It's been a month since i start learning how to code. If you have a time please review my code and let me know if something i should look into or if there is any method that I'm using wrong.
Doing hover on image was pretty challenging but i managed to figure it out. As I keep doing these challenges i get more confidence on structure and using the modern css methods.
Thank you in advance !
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should replace the <div class="attribution"> to <footer class="attribution".
- footer can contain informations about author, copyright etc.
<body> <footer class="attribution"> </footer> </body>I hope you'll find this helpful, and your solutions is really good. 😌
0 - Eni• 180
@EnidaShehu
Submitted
Any feedback is much appreciated :)
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should add an <main> tag after body and before the div tags.
- The <main> tag specifies the main content of a document.
- You should put the <div class="attribution"> outside the <main> tag
- Then replace the <div> tag by semantic tag <footer>
- footer can contain informations about author, copyright etc.
HTML
<body> <main> .... </main> <footer class="attribution"> </footer> </body>I hope you'll find this helpful, and your solutions is really good. 😌
Marked as helpful
0 - ifeanyi• 90
@ifeanyiagujekwu
Submitted
relative positioning responsiveness
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should add an <main> tag after body and before the div tags.
- The <main> tag specifies the main content of a document.
- You should put the <div class="attribution"> outside the <main> tag
- Then replace the <div> tag by semantic tag <footer>
- footer can contain informations about author, copyright etc.
HTML
<body> <main> .... </main> <footer class="attribution"> </footer> </body>CSS
- You should add an .attribute for footer
- Then in .attribute you can set the position to get the footer at center.
0 - Eunil• 100
@EunilCarl
Submitted
just built this after not coding for 2months and i forgot almost everything lol
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should put the <div class="attribution"> outside the <main> tag
- then replace the <div> tag by semantic tag <footer>
- footer can contain informations about author, copyright etc
HTML
<body> <main> .... </main> <footer class="attribution"> </footer> </body>I hope you'll find this helpful, and your solutions is really good
0 @MomentTUM
Submitted
Yash Joshi• 450@yashgjoshi20
Posted
Hi There,
I think you should add the favicon (i.e the little symbol on your tab) which shows the website icon you use. Its simple to add you just need to Declare a link in the header section of your HTML.
<link rel="icon" href="favicon.ico">Hope I am Helpful. 😌
Marked as helpful
0- kalmod• 20
@kalmod
Submitted
- Box-shadow, font-size, and setting the right flex properties on the children.
- What are usually the best approaches to take when approximating the size of content?
Yash Joshi• 450@yashgjoshi20
Posted
Hey well done for completed this challenge😁
I have some suggestions to help you to improve your solution :
- You should put the <div class="attribution"> outside the <main> tag
- then replace the <div> tag by semantic tag <footer>
- footer can contain informations about author, copyright etc
HTML :
<main> </main> <footer class="attribution"> </footer>I also make pull requests on your Github repo so you can merge it if the changes suit you
I hope you'll find this helpful, and your solutions is really good 😁
Marked as helpful
1 - Eni• 180
@EnidaShehu
Submitted
Any feedback or suggstion is much appreciated :)
Yash Joshi• 450@yashgjoshi20
Posted
- You should use grid-column to get the images and the Features separated side by side.
- When you do that then its simple CSS to get the sizing right.
- The Container would help in this to get the perfect sizing.
- Also for the button you can resize it using padding or margin depending on your choice. 😌
Marked as helpful
0 - Eni• 180
@EnidaShehu
Submitted
- What could I have done differently without using Bootstrap?
- What is something that needs to be changed about the code?
Yash Joshi• 450@yashgjoshi20
Posted
- You can set the container in the middle of the screen then whatever changes user makes can be added in properties of the styles.css later on to perfect it.
- You can add the .container { display: absolute; top:50%; left: 50%; transform: translate(-50%, -50%); } .
Marked as helpful
0
