Skip to content
OverviewSolutions
3
Comments
9

y brown

@yosefbrowncodeIsrael190 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

I’m currently learning...

VueJS Tailwind CSS and hopefully Node js

Latest solutions

Latest comments

  • y brown•190
    @yosefbrowncode

    Yacine,

         This is great work. I am very impressed by the additional animation that you added. it makes it very clear where your new link is located. Keep up the great work.

    One thing that I would suggest is to add some sort of error when a person adds an invalid link or just some random text. at the moment your solution does not have that.

    Other than that Amazing work.

    Keep it up

    Marked as helpful
  • y brown•190
    @yosefbrowncode

    Very good work Amjed, you did an amazing job with the responsiveness of this project. One thing that I did on the larger screens sizes was make the search/filter bar absolute so the cards don't get pushed down when it pops up. On mobile kept it normal because the filter tags have to wrap around and the div below needs to move when it grows.

    Try that if you want. Again amazing work. Keep it up

  • y brown•190
    @yosefbrowncode

    Great work. What happened to the link shortening part? It is actually not so hard, try and do it with Axios for the api calls if you are using React. I did it and I learned a lot about api calls etc. The responsiveness is good. there are a couple parts where the cards get squeezed, but other than that keep up the good work!

  • y brown•190
    @yosefbrowncode

    This is amazing work. It is responsive which is great, I have seen a lot of projects that are not so responsive.

    One small suggestion, I would make the "search/filter box" position absolute on bigger screens that way it wont push down the cards.

    There is not much to do about the cards going down on smaller screens unless you give a big margin, but then the design does not look nice.

    Thumbs up and great work.

  • y brown•190
    @yosefbrowncode

    Shalom Keep up the efforts.

     I would use something like bootstrap if you have never used it before?

    It will help you learn about responsiveness. I have learned a lot from it and I am now able to use CSS if necessary to make sites responsive. It will contain all the elements in there places if used correctly. here I see it was a bit of a struggle with the cards and parts of the design overlapping.

    Keep up the good work. all the best

    Marked as helpful
  • y brown•190
    @yosefbrowncode

    Hey great work,

            There are a few things I would try and work on.

    1. User should have the ability to shorten multiple links. Here you can only paste one at a time.

    2. The copy button turns to copied but never goes back to copy. if you plan on having only one link shorten card, I would suggest that you change back the button once a new link is shortened.

    3. The line behind the cards is actually not as hard as it looks. check my solution for ideas if you want - https://www.frontendmentor.io/solutions/responsive-link-shortening-page-css-html-js-bootstrap-axios-oRkOrRZaJg

    Overall great work. Keep it up

View more comments