Skip to content
OverviewSolutions
28
Comments
18
Yunus Ujjaini
@yunus-ujjaini

All comments

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Everything works soo smooth, Loved it.

  • Yunus Ujjaini•565
    @yunus-ujjaini

    The website looks great, I am just unable to click on navigation dropdown options as it disappears when not hovering over the nav item.

  • Yunus Ujjaini•565
    @yunus-ujjaini

    On width < 400px your text on landing page is overflowing.

    Apart from that Great job on this challenge! Happy coding

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Looks great!

    Just avoid using div for tip selectors as they cannot be accessed when using a keyboard, Instead use buttons for interactive elements.

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Your solution looks great, both design and functionality wise.

    Well one user experience issue I observed is...

    -> Add bill amount, no of persons, and add a custom tip of say 2%

    -> Select a tip from listed options, recalculation of values will be done as per new tip percentage.

    -> Click on custom tip again. Recalculation is not happening as per custom tip unless we remove existing value and retype our tip.

    You can fix this if you want otherwise everything is perfect ✨

    Happy coding !!

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Great work on this challenge. ✨

    Beautiful animations, I submitted solution to this challenge today and on suprise I found 'up and down' arrow animation that you have added is the same animation I have implemented as well.

    You can probably work on getting that arrow halfway over the orange(image). Apart from that everything looks perfect.

    Marked as helpful
  • Yunus Ujjaini•565
    @yunus-ujjaini

    Nice job on this challenge ✨.

    I really liked that button press type effect on download buttons.

    Happy coding 😀

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Everything looks good ✨

    You can probably work on getting that arrow to stay halfway over the orange (image).

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Great job with this challenge. There is just a tiny space getting left out on all the sides of the content, though it looks cool; But if you want to remove the same you set the margin of body to 0.

    And I have submitted my solution using sass. Feel free to check it out.

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Hi Grace,

    The solution looks good, I think you have forgotten to change the background image of the header for desktop design.

    instead of url(../images/bg-header-mobile.png) it should be url(../images/bg-header-desktop.png)

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Hi Agata.

    I went through most of your solutions they are all really nice. One thing I noticed In this solution - after creating a plan we get the checkout modal in which if we press and hold the checkout button, the price from the left corner is sliding over to the right side.

    Happy coding :)

  • Yunus Ujjaini•565
    @yunus-ujjaini

    I loved it ❤️

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Ohhh thanks for bringing this up. Would you be able to tell me what is the screen width and height?

  • Yunus Ujjaini•565
    @yunus-ujjaini

    For getting "Enter valid email" error. You can use psuedo elements like after and before to design your error message, place your error message at right position by using absolute positioning. Once that is done, you can simply hide and show this psuedo element on incorrect input. Please note that you cannot have psuedo elements on inputs directly, so probably wrap your input in some container to make it work.

    And for changing color of SVG you can use 'fill' attribute.

    Happy coding 😊

  • Yunus Ujjaini•565
    @yunus-ujjaini

    You're making mistake which I used to make. I tried now in mobile and it's working really nice. But when I'm shrinking my browser window it's breaking.

    You probably might be using max-device-width in media queries. Try using max-width for full support :)

  • Yunus Ujjaini•565
    @yunus-ujjaini

    You have mastered it in Desktop layout. It looks very beautiful

    Try making it responsive as well, it wont take much time :)

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Hi,

    The website looks good, On middle-sized devices, it is breaking. Though can be fixed.

    Nice animations though it seems like you have forgotten to change the hamburger icon to the close button when menu is opened on mobile devices.

    Keep going

  • Yunus Ujjaini•565
    @yunus-ujjaini

    Superb job with animations and designing :)

    only one issue which I noticed: Filtering options are working properly functionality wise but 'All' stays selected all the time even when you switch to completed tasks or active tasks.

    Apart from that everything seems perfect. Cheers