@emestabillo
Posted
Hey Alex, I would put the white borders on the buttons from the get-go. This way, you are only changing the background color on hover, instead of adding an additional 2px around the button which is causing the unintended shift.
For your html, there's more than one h1 in your site, which should not be the case. Since there's no single stand-out heading in the design, I would use a hidden heading instead, like <h1>Car Rentals</h1> and hide it with an .sr-only class. Here's a brief article on it.
I suggest you consider flex or grid for your question about the footer. Absolute positioning will make the attribution overlap the content if the viewport height is less than the height of the content. It would also be great to make the site responsive by including code for medium widths.
Hope this helps!
@alexvalpeter
Posted
@emestabillo Hi there, thanks for your suggestions! I love your idea for the hidden heading, I will definitely try to incorporate that. I had considered using grid for the footer, but I wasn't sure if it was bad practice to have nested grid elements, though you're definitely right that it would solve a lot of my problems. Thanks again!
