Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

A lot of CSS Grids: SCSS and JS

Nic 595

@nicm42

Desktop design screenshot for the Manage landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View Challenge

Design Comparison

SolutionDesign

Reports

Accessibility report (5)
error

Anchor element found with a valid href attribute, but no link content has been supplied.

<a href="#testimonials__person1"><div class="testimonials__dot f...</a>
error

Anchor element found with a valid href attribute, but no link content has been supplied.

<a href="#testimonials__person2"><div class="testimonials__dot" ...</a>
error

Anchor element found with a valid href attribute, but no link content has been supplied.

<a href="#testimonials__person3"><div class="testimonials__dot" ...</a>
error

Anchor element found with a valid href attribute, but no link content has been supplied.

<a href="#testimonials__person4"><div class="testimonials__dot" ...</a>
error

This emailinput element does not have a name available to an accessibility API. Valid names are: label element, title undefined, aria-label undefined, aria-labelledby undefined.

<input class="footer__input" name="footer__input" type="email" placeholder="Updates in your inbox…" required="">

Nic’s questions for the community

I haven't really used a lot of CSS Grids, so I learnt a lot using them in this one. I also learnt Gulp, which took forever to learn how to use, but was really useful once I got it working.

I'm not sure I'm using SCSS to its full potential - it's pretty much just CSS with some variables. What can I do to make better use of it?

Community Feedback

Adarsh Pratap 5,515

@adarshcodes

Posted

Hey! @nicm42, your solution looks fine. You can change a few things like

  • font-weight for and size for the navbar links.

Few things to improve responsiveness

  • At breakpoint 870px around you can make changes to the navbar links.

  • Increase the font size just a bit.

  • Solve the Accessibility and HTML issues.

  • I haven't learned the SCSS yet, so can't tell you much about it, but you can use mixins and there's a lot to make you code reusable and shorter :)

Great work!

1

Nic 595

@nicm42

Posted

Thank you.

Annoyingly, I have fixed the HTML and Accessibility issues, but when I tell FrontEnd Mentor to check again, it's still checking the old html file, even though I can definitely see the new one in GitHub.

0

Please log in to post a comment

Log in with GitHub
Slack logo

Join our Slack community

Join over 160,000 people taking the challenges, talking about their code, helping each other, and chatting about all things front-end!