@vanzasetia
Posted
👋Hi Sloth!
Thanks for leaving kind words on my solution!
I can close the panel that I opened, in my opinion there's nothing wrong with it.
Some feedback on this solution:
- For the icon arrows, they are decorative images. You can add
aria-hidden="true"
and leave thealt=""
. - For
padding
,margin
,gap
, I recommend to userem
orem
units instead of%
. The reason for that is, you can't limit themax padding
, which means it might not be looking good on wide screen. - Also
640px
is too early to change the layout into two columns. - Try to do this challenge using JavaScript, since the non JavaScript version is just additional challenge.
That's it! Hopefully this is helpful!
Marked as helpful
@Sloth247
Posted
@vanzasetia Thank you very much for your feedback! I meant closing all other panels when one panel is open, but I guess I need to use JavaScript to make this work.
I will reflect your advice and will update my solution. Thank you very much 😊