Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice API using SASS and BEM

#bem#sass/scss#fetch
Vuekoā€¢ 160

@Vueko1

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello ! Could you please take a look at my code to make sure there are no mistakes ? Also I would like to know how to control the color and ratio of svg images you provided using css ( I found filter property but it turned out to be troublesome for me :P )

Community feedback

Vuekoā€¢ 160

@Vueko1

Posted

Also ! I wonder why on mobile rolling the dice gets new advice instantly and on pc ( chrome in my case ) it seems to have a cooldown of few seconds ( like after clicking you have to wait a while before next one can be get )

0
P
Emmilie Estabilloā€¢ 5,540

@emestabillo

Posted

Hi @Vueko1, looks good. Can't tell if there's an issue with the svgs because it seems ok! Just a few thoughts:

  1. Use rem in place of px
  2. .dice-frame requires user interaction, and thus should be an interactive element button in this case, rather than a div.
  3. I think .wrapper can do away with all the flex properties. Its contents would still look centered and would likely just need padding in between. Less code, if you will.
  4. Hover on the dice could use a smooth transition

Hope this helps!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord