Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 4 months ago

Advice Generation ReactJs

react, vite
kudos2Shef•190
@kudos2Shef
A solution to the Advice generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

This is my first project using an API with fetch in ReactJS and it's also my first-ever ReactJS challenge. I used fetch to render data, ReactJS functional component for code reusability and useState hook to manage state in this project.

What challenges did you encounter, and how did you overcome them?

The implementation of functional components in React was challenging for me, as I haven't coded in React this way before.

What specific areas of your project would you like help with?

I would appreciate any feedback on my code regarding how I should have approached this challenge in React and what else i can add .

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Jakub Strzyżykowski•260
    @jstrzyzykowski
    Posted 4 months ago

    Good job!

    One small tip:

    • define new local state called "isLoading" as a flag
    • switch this flag each time when your request is pending
    • when "isLoading" is true, you can display some kind of loader on UI

    It will significantly improve user experience 🙂

    Keep going!

    Marked as helpful
  • Sophie•430
    @ippotheboxer
    Posted 4 months ago

    Well done, the app looks great, and I like the animation you added with the dice. Your code is lean and well written. One thing you could have done in regards to getting the data with fetch, instead of setting the initial value to something hard coded along with the id, you could use useEffect and call fetchAdvice:

    const [advice, setAdvice] = useState("")
    const [id, setId] = useState()
    
        useEffect(() => {
            fetchAdvice() 
        }, []) // empty dependency array means this is used on render
    

    Whilst leaving everything else the same. This means you don't have a hard coded initial value, and useEffect will be used initially when the app is loaded and on any refresh.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub