I am a self-taught frontend developer looking for an opportunity to strengthen my insight in the technical field. Currently, I have expertise in HTML/CSS and JS (React Js, jQuery, Bootstrap).
I’m currently learning...Heading towards a full-stack developer voyage. I'm hoping to be there soon.
I would appreciate any feedback on my code regarding how I should have approached this challenge in React and what else i can add .
This project is interesting. Any feedback will be appreciated.
want to have easy coding.
What challenges did you encounter, and how did you overcome them?responsive.
What specific areas of your project would you like help with?responsive is not working.
@Bobu007 Congratulations on completing this challenge 👏. Your solution is great and responsive as well.
Few suggestions on your code:-
There is no need to use flex in body element. If you want to use it, apply to a div/section instead. Within this div/section, you can write your .cards and .attribution classes. The flex in the body tag is causing your .attribution div to be displayed in a row instead of a column .
In the .cards, add:
max-width:fit-content;
margin:auto;
Use max-width along with min-width to make your code more efficient.
text-align:center; in .attribution class . There is no need of position:absolute;, as absolute positioning is used for layering elements on top of each other, which prevents proper text alignment. Instead, use relative, which keeps elements positioned one after another.Hope this helps! Happy Coding
@tiagocoutinho-ts
Congratulations on completing this challenge. Your solution is great and well written 👍.
We are provided with a style guide when we download assets related to a challenge. All the information about colors and fonts are mentioned in the style-guide document, so please refer to it. We don't need external sites to provide anything.
Hope this helps. Happy Coding!
Hi @bakellian , you have done a great job in attempting this challenge 👏.
In this challenge, we are provided with two images - product-mobile and product-desktop.
product-mobile img is used for both mobile and desktop version in your code.
<img src="./images/image-product-mobile.jpg">
For landscape images just change img src , no need for zoom out.
Hope this helps, Keep up the good work!!
Hi @leevaan your solution is commendable 👍, especially the comma after every three digits. Keep it up.
Hi @semer53, Congratulations on completing this challenge. Your solution is great👍
Just a reminder the image src is not correctly mentioned try changing to this or copy GitHub image path
<img src="images/image-qr-code.png" alt="">
also alt attribute shouldn't be empty at times like this when image is not loaded the text in alt attribute will be shown.
Hope this helps, Happy Coding
applying the hover effect
Hi @mfq17s,
I came across your solution its perfect . Just a reminder you forgot to add active state in Jules wyvern text.
Keep up the good work!
