Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Flexbox, Responsive Web Design

#accessibility#bem
kudos2Shefβ€’ 160

@kudos2Shef

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback are welcome!. Curious to know, what are the best way to solve this challenge.

Community feedback

Christianβ€’ 970

@FLCHRIS

Posted

Hi!, congrats on completing this challenge. πŸ₯³πŸŽŠ

Here some tips to improve your code. πŸš€

Background images are for decorative purposes, they do not add value to your website. What you can do to fix it is the following, add the aria-hidden='true' attribute and set the alt attribute to empty, like so alt=''. You can also choose to use the background-image property, thus avoiding using the above.

Example:

<img src="images/pattern-background-desktop.svg" id="img1" alt="" aria-hidden='true' >
<img src="images/pattern-background-mobile.svg" id="img2" alt="" aria-hidden='true' >

I can see that you have a little reset for the default styles that the browser gives, that's ok. But you can improve it by using other resets like the following:

Your solution is very good. πŸ’―

Happy coding! βœŒοΈπŸ™ƒ

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord