Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator App

@Khemmie-Ray

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Is the use of negative margin bad practice? What are the best alternatives to that?

Community feedback

Keytron 270

@Dev-Tron

Posted

It is not a bad practice to use negative margin. A general rule of thumb is that if it looks good then it usually is good. You could also simply apply position: relative; to your parent divs and then the position: absolute values (ie. top:; right:; bottom:; left:;) to child elements which can help you avoid using negative values greatly.

Marked as helpful

0

@karaaa006

Posted

You can use transform: translateY(50%) for that

Marked as helpful

0
P

@nikoescobal

Posted

Hello there! 👋

Congratulations on finishing your challenge! 🎉

I think using negative margins is completely fine, although it should only be used when necessary. The alternative is to use absolute positioning -- keep in mind that if you do use absolute positioning, the parent container must have a position relative applied to it.

Here's some other feedback on this solution:

  • you forgot to add the quotation marks
  • You can add width to your content + text-align-center to make it look like the original design
  • check the report to fix accessibility issues - you currently have 5 listed

I hope this is helpful and all the best with your coding journey!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord