Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator App

@matheuspergoli

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I always hate working with images, it's my "Kryptonite", any help on that I'd appreciate, I'm still learning the basics of JS so, any help on that too is very welcome :)

Community feedback

Abdul 8,560

@Samadeen

Posted

Hey!! Cheers 🥂 on completing this challenge.. .

Here are my suggestions..

  • You should use <main class="main-box"> instead of <div class="main-box">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
  • You should add a alt text to your img tag to aid screen-readers.

This should fix most of your accessibility issues

. Regardless you did amazing... hope you find this useful... Happy coding!!!

1

@matheuspergoli

Posted

@Samadeen Thanks for your feedback :D

0
P

@karthik2265

Posted

Looks great, well done 👏

I liked how you used HTML custom data properties for selection in js. The js code is well written and easy to read. why did you place the js and css files in the assets folder, I think they go in a separate folders or just in the root.

You forgot to add the hover effect for the button, you can easily add the effect with the following code box-shadow: -1px 0 40px 2px var(--Neon-Green), 1px 0 40px 2px var(--Neon-Green); filter: brightness(1.1);

1

@PaliTriesToDesign

Posted

@karthik2265 and don't forget to add a nice transition to it c:

.data-btn-generator {
     transition: all 200ms ease-in-out
}
2

@matheuspergoli

Posted

@karthik2265 Thanks for your help man, I didn't know how to do that glowing effect :)

0

@igor-ostojic

Posted

Hey ! Great work so far !

So for the element "data-btn-generator" If you want to make it a perfect circle, it needs to have both a height and a width with the border radius at 50%.

As for the JavaScript, it all looks good to me !

1

@matheuspergoli

Posted

@igor-ostojic Thanks for your feedback! :D

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord