Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator App with JS CSS and HTML

Sousa 100

@Pedro-S-Vicente

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


All comments are welcome

Community feedback

Dytoma 570

@Dytoma

Posted

Hey, Good job on completing this challenge however I do have some recommendations for accessibility:

  • First I'll suggest you add an aria-label attribute to your button as there is no text to describe the button and an aria-hidden="true" to the image inside the button for screen readers to escape this element. <button id="randomAdvice" aria-label="new advice"><img src="./images/icon-dice.svg" alt="Dice" srcset="" aria-hidden="true"></button> .

You can read more about ARIA :

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord