Skip to content
Submitted over 2 years ago

Advice Generator App with JS CSS and HTML

Sousa•100
@sousa-p
A solution to the Advice generator app challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

All comments are welcome

Code

Please log in to post a comment

Log in

Community feedback

  • Dytoma•550
    @Dytoma

    Hey, Good job on completing this challenge however I do have some recommendations for accessibility:

    • First I'll suggest you add an aria-label attribute to your button as there is no text to describe the button and an aria-hidden="true" to the image inside the button for screen readers to escape this element. <button id="randomAdvice" aria-label="new advice"><img src="./images/icon-dice.svg" alt="Dice" srcset="" aria-hidden="true"></button> .

    You can read more about ARIA :

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord