Skip to content
OverviewSolutions
13
Comments
20

Dytoma

@DytomaTogo550 points

👋Hello I'm Dytoma, I'm a front-end developer and I'm a self taught.

I’m currently learning...

I'm currently learning Next Js.

Latest solutions

View more solutions

Latest comments

  • Dytoma•550
    @Dytoma

    Hey👋

    Good job on completing this challenge 👏

    I have some feedback for you:

    • First you can look at the Accessibility Report and the HTML validation report. You can find useful information about you code. When using the ul element make sure you use li elements as children and then you can wrap the content in an anchor tag. So your code might look something like this <ul> <li><a href="">Home</a></li> <li><a href="">New</a></li> <li><a href=""> Popular</a></li> <li><a href=""> Trending</a></li> <li><a href=""> Categories</a></li> </ul>

    • Secondly the hover effects provided by the design system are absent, you can implement that too to your code. You can read about hover effect on MDN docs hover📚

    Happy coding🙌

    Marked as helpful
  • Dytoma•550
    @Dytoma

    Hey👋

    Good job on completing this challenge👏you've done a great job

    However I have some suggestions that you can use to improve your code:

    • Firstly when you submit a solution, you can have a look at the Accessibility Report and the HTML Validation Report that gives you useful information and some mistakes that you would want to solve. You can see in the reports that you use multiple IDs twice and as you know IDs have to be unique so you can change one of the duplicated ones.

    • Secondly I'll suggest you use classes instead of IDs. It helps you avoid multiple debugging problems and classes allows you to style multiple elements at a time. There's more reasons to that, you can read more about this on class vs id DEV article.

    • Lastly instead of using your <div id="banner-image"></div> empty, I suggest you append an img element to that div and then use object-fit property in CSS to style as you want.(<div class="banner-image"><img src="./assets/images/image-web-3-desktop.jpg" alt="Desktop image"/></div>).

    That's all for me, Happy coding🙌

  • Dytoma•550
    @Dytoma

    Hey👋

    Good job on completing this challenge👏

    I have some feedback that you can use to improve your code:

    • First instead of using article elements, I will suggest you use div elements and give them a role attribute(eg: <div role="main">....</role>).
    • For the <div class="attribution">......</div> you can add a role="footer" you can learn more about landmarks here. And for <img src="./assets/images/illustration-thank-you.svg" alt="Illustration" class="article__illustration"> I will suggest you add an aria-hidden='true' attribute for screen readers to skip this image as it just serves for decoration.

    Happy coding🙌

    Marked as helpful
  • Dytoma•550
    @Dytoma

    Hey👋

    Good job on completing this challenge👏 the animation on the advices looks amazing

    I have some suggestions you might want to implement to improve your code:

    • First you don't need the <header></header> and the <footer></footer> elements as they have empty content thus useless to your code and you could also put your h1 in the main element.
    • For your button, I suggest you give it an aria-label="new advice" and to the image an aria-hidden="true" as the image just serves for decoration. You cam learn more about ARIA.

    Happy coding👏

  • Dytoma•550
    @Dytoma

    Hey👋

    Good job on completing this challenge👏

    However I thing you forgot to implement the javascript part for the carousel images and text. And your website is not responsive for mobile versions; you might want to look at that to. If your goal was to just code the layout of the page then congrats👏👏 I hope you will take some time to improve your solution.

    Happy coding

  • Dytoma•550
    @Dytoma

    Hey 👋

    Good job on completing this challenge👏

    If you want to have feedback, you should consider adding a repository for others to access your code. The link to your repository is showing a 404 error. Other than that your solution is perfect, responsive for all devices. Congratulations👏

    Marked as helpful
View more comments