@Bayoumi-dev
Posted
Hey! It looks great!...
My suggestions:
Buttons must have the discernible text
, So don't leave thealt
attribute empty when using the imageimg
inside the button<button>
without text.
<button class="btn">
<img src="./images/icon-dice.svg" alt="Advice Generator">
</button>
Or set the attribute aria-label
to describe the button.
Document should have one main landmark
, Contain the component with<main>
.
<main>
<div class="container">
//...
</div>
</main>
-
Page should contain a level-one heading
, Change<p class="advice-id">advice #117</p>
to<h1 class="advice-id">advice #117</h1>
You should always have oneh1
per page of the document... in this challenge, you will useh1
just to avoid theaccessibility issue
that appears in the challenge report... but don't useh1
on small components<h1>
should represent the main heading for the whole page, and for the best practice use only one<h1>
per page. -
All page content should be contained by landmarks
, Contain the attribution with<footer>
.
<footer>
<div class="attribution">
//...
</div>
</footer>
Hope this is helpful to you... Keep coding👍
Marked as helpful