Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator Using APIs

Sharon 170

@siafromspace

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Ahmed Bayoumi 6,800

@Bayoumi-dev

Posted

Hey Sharon, It looks good!... Here are some suggestions:

  • Document should have one main landmark, Contain the component with <main>.
<main>
   <div class="container">
      //...
   </div>
</main>
  • Page should contain a level-one heading, Change <p id="advice-no"></p> to <h1 id="advice-no"></h1> You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • use <button class="dice"> instead of <div class="dice">... Buttons are used for actions.

<button class="dice">
      <img src="images/icon-dice.svg" alt="Advice Generator" class="click-dice roll-dice">
</button>

Hope this help!... Keep coding👍

Marked as helpful

1

Sharon 170

@siafromspace

Posted

@Bayoumi-dev will work on the code asap. thank you sm !

0
Ahmed Bayoumi 6,800

@Bayoumi-dev

Posted

@siafromspace You are welcome😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord