@Bayoumi-dev
Posted
Hey Sharon, It looks good!... Here are some suggestions:
Document should have one main landmark
, Contain the component with<main>
.
<main>
<div class="container">
//...
</div>
</main>
-
Page should contain a level-one heading
, Change<p id="advice-no"></p>
to<h1 id="advice-no"></h1>
You should always have oneh1
per page of the document... in this challenge, you will useh1
just to avoid theaccessibility issue
that appears in the challenge report... but don't useh1
on small components<h1>
should represent the main heading for the whole page, and for the best practice use only one<h1>
per page. -
use
<button class="dice">
instead of<div class="dice">
... Buttons are used for actions.
<button class="dice">
<img src="images/icon-dice.svg" alt="Advice Generator" class="click-dice roll-dice">
</button>
Hope this help!... Keep coding👍
Marked as helpful
@siafromspace
Posted
@Bayoumi-dev will work on the code asap. thank you sm !
@Bayoumi-dev
Posted
@siafromspace You are welcome😊