Advice Generator Using APIs

Community feedback

• 

  Ahmed Bayoumi•6,700

  @Bayoumi-dev

  Posted almost 3 years ago

  Hey Sharon, It looks good!... Here are some suggestions:

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="container">
        //...
     </div>
  </main>
  

  • Page should contain a level-one heading, Change <p id="advice-no"></p> to <h1 id="advice-no"></h1> You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • use <button class="dice"> instead of <div class="dice">... Buttons are used for actions.

  <button class="dice">
        <img src="images/icon-dice.svg" alt="Advice Generator" class="click-dice roll-dice">
  </button>
  

  Hope this help!... Keep coding👍

  12

  Marked as helpful