Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice-Generator

@shaughnroque

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Finished this a while back and forgot to post the solution. Had some trouble at first to get the api to work with github pages but found a solution to that. Any feedback is welcome! Thank You!

Community feedback

@efecollins

Posted

Hello @shaughnroque, congrats. You made a beautiful project. I have some suggestions for improvements which you can add upon your consideration.

  • It's good practice to have your h1 before any other headings. You can change this <h2 class="id">ADVICE #</h2> to <h1 class="id">ADVICE #</h1>.

Also, change <h1 class="quote">""</h1> to a paragraph element or blockquote.

  • I haven't been able to find a solution to this but you can. For the responsiveness, from 701px - 1088px, your advice-app becomes distorted.

I know you can solve this. Cheers!

Marked as helpful

0

@shaughnroque

Posted

@efecollins Thank you for the feedback! I will look into the responsiveness from 701px - 1088px.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord