Skip to content
Submitted over 2 years ago

Advice-Generator

Shaughn Roque•150
@shaughnroque
A solution to the Advice generator app challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Finished this a while back and forgot to post the solution. Had some trouble at first to get the api to work with github pages but found a solution to that. Any feedback is welcome! Thank You!

Code

Please log in to post a comment

Log in

Community feedback

  • Efosa Collins EVBOWE•365
    @efecollins

    Hello @shaughnroque, congrats. You made a beautiful project. I have some suggestions for improvements which you can add upon your consideration.

    • It's good practice to have your h1 before any other headings. You can change this <h2 class="id">ADVICE #</h2> to <h1 class="id">ADVICE #</h1>.

    Also, change <h1 class="quote">""</h1> to a paragraph element or blockquote.

    • I haven't been able to find a solution to this but you can. For the responsiveness, from 701px - 1088px, your advice-app becomes distorted.

    I know you can solve this. Cheers!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord