Skip to content
OverviewSolutions
10
Comments
20

Efosa Collins EVBOWE

@efecollinsIbadan, Nigeria365 points

Creative and self-starting Front End Developer with 1+ years of experience building and maintaining responsive websites in a collaborative environment. Proficient in HTML, CSS, Sass and JavaScript with working knowledge of Bootstrap and jQuery.

I’m currently learning...

Database using MongoDB & Mongoose

Latest solutions

View more solutions

Latest comments

  • Efosa Collins EVBOWE•365
    @efecollins

    @johnv2309 you did well on this project.

    There's nothing wrong with your JavaScript, It's probably your internet. Every other thing is ago but if you still insist on changing the code for the API calls, you can check my solution here.

    Cheers!

  • Efosa Collins EVBOWE•365
    @efecollins

    Hello @shaughnroque, congrats. You made a beautiful project. I have some suggestions for improvements which you can add upon your consideration.

    • It's good practice to have your h1 before any other headings. You can change this <h2 class="id">ADVICE #</h2> to <h1 class="id">ADVICE #</h1>.

    Also, change <h1 class="quote">""</h1> to a paragraph element or blockquote.

    • I haven't been able to find a solution to this but you can. For the responsiveness, from 701px - 1088px, your advice-app becomes distorted.

    I know you can solve this. Cheers!

    Marked as helpful
  • Efosa Collins EVBOWE•365
    @efecollins

    Hi @Merxibeaucoup, congrats on completing this challenge. I have a few things I think you should do if you would:

    • The nav bar can't be closed, I had to refresh the page to make it go away. Kindly, follow the replies above to solve that.

    • The background image for your .header div is moving from its place. Add a background-position: center; to make it go nowhere.

    Keep pushing forward on your coding journey. Cheers 👍

  • Efosa Collins EVBOWE•365
    @efecollins

    Hello @vampmora, well-done on trying to make the code work but there is a little change that can be implemented if you will:

    • For accessibility's sake, you can add a role="contentinfo" attribute to your .attribution div. The former becomes:
    <div class="attribution" role="contentinfo">
</div>

    👍 Enjoy your coding journey. Cheers!

  • Efosa Collins EVBOWE•365
    @efecollins

    @Omeshcoding great work. Kudos

    There are a few things you can do as per accessibility.

    • The main tag shouldn't be in the header tag.
    • The h1 tag should be the heading of your website meaning it can't be in the main tag.

    For the rest, I must say, you're good.

  • Efosa Collins EVBOWE•365
    @efecollins

    @Katleho-codes you did a good job but you didn't use the API provided. You can take a look at my solution @ my solution

    Your img tags don't have alt attributes. It's good practice to always include that <img src="./images/icon-dice.svg" alt="Dice image">

    I guess this is greAT. wELLDone

    Marked as helpful
View more comments