Article Preview Component

Community feedback

• 

  Azhar•600

  @azhar1038

  Posted almost 3 years ago

  Hi Jane, wonderful work there!

  Positioning the popup in desktop was probably the most difficult part of this challenge (at least for me 😅). For x-axis I used % value instead of fixed amount along with translateX and calc to position the popup.

  First you will have to position that section w.r.t that bottom footer where the share button is present, then do:

  .popup {
      left: 100%;
      transform: translateX(-50%);
  }
  

  This will move the center of popup to the right boundary. Then do some calc to negate the padding and half of the share button size to move it left to the center. Check out my solution: Article preview component

  Another accessibility tip, the extra close button that you have added, try to make it a button instead of div and give it an aria-label if you are using some fancy characters which screen readers may not understand.

  One small issue I noticed with mobile view is the size of card changes when share menu opens because author part and share menu have different height.

  Hope it helps :)

  10

  Marked as helpful