@adarshcodes
Posted
Hi @Shubham Sharma, Welcome to the Frontendmentor community and congratulations on completing your first solution๐๐๐ Your solution looks nice but you can modify and take care of it from the next project.
So, let's started with your design-
- The design looks pretty good.
- There is a bit of change needed in the search bar:
1). Add padding-left to the search bar. So, while typing the text start with some distance from the corner of the box. 2). Change the input text-color to the same as the place holder text color. 3). You can change the background color of the Search bar to transparent so that it matches the main background and look more similar to design.
.form_input : { padding-left: 4rem; color: #DD959B; background: transparent; }
4). Change the cursor hover effect to the pointer when the user hovers at the arrow button attached to the search bar.
.form__submit-btn { cursor: pointer; }
About Responsiveness-
-You can add one breakpoint for responsiveness at 1056px, 700px, and at 480px around so that the responsive design will work great๐
About Code-
-Your code is well organized and easy to understand. Great!๐
Accessibility and HTML issues-
-Solve the Accessibility and HTML issues that arose above๐ฑโ๐.
Keep Coding Brother๐ฑโ๐ป
@shubhamthedev
Posted
@adarshcodes thank you for the corrections these small things just went right past me and i've corrected all the issues you've suggested.