Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Base Apperel Using Simple HTML, CSS & JS.

Sky 945

@Skyz03

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This one is was one of the best interesting challenge that i completed with a lot of helpful resources. Any feedback to take this to the next level is highly appreciated. Thanks in advance.

Community feedback

Amon 2,560

@A-amon

Posted

Hello! Great job~

I have a few suggestions for you (that could level it up! 😀)

  • Put the main content of your site inside main tag. (Then, regenerate the report)

  • Put input element, .error and #errorImg inside a div. This way, when you absolute position your #errorImg, it will be relative to the div instead of the form. (So that you don't have to manually set the value for #errorImg's left to 17rem. Instead, you just need to set right:0)

  • The alt describes the image but in the case of your submit button, it describes the action. E.g. Send email/ Submit.

  • Instead of setting the style directly in JS to show/hide something, add/remove or toggle class instead. E.g. adding .error class to show error-related styles.

I learnt about validity.valid, thanks to you! 😀

Marked as helpful

1

Sky 945

@Skyz03

Posted

@A-amon Thanks for the valuable feedback will surely implement this out.

0
Amon 2,560

@A-amon

Posted

@Skyz03 Glad to help!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord