@mattstuddert
Posted
Awesome work, Norberto! I'm not actually getting a horizontal scroll on mobile. Have you fixed it? You've done a really good job on this challenge.
A couple of things you could do would be:
- Add form validation in the newsletter sign up
- Re-factor your JS for the features section to reduce code duplication. You've taken a good approach with looping over elements for the FAQ items. This would be a good approach for the feature section as well.
You've done a really good job. Keep up the great work! 👍
@theAspiringDev1
Posted
@mattstuddert Thanks man! Ill refactor it. Google chrome has that weird horizontal scroll xD. and up till now i dont even know what was causing it
@mattstuddert
Posted
@theAspiringDev1 ah yeah, I've just seen it. Setting overflow-x: hidden on the body doesn't work. I can't remember the exact reason but the way to resolve it is to add an element just inside that wraps all of the content like this:
<body>
<div class="wrapper">
</div>
</body>
Then add it to the .wrapper class instead. It will be because of your absolutely positioned background patterns. Let me know if that resolves it! 👍
@theAspiringDev1
Posted
@mattstuddert That fixed it! Thank you ! I learned from it!
@mattstuddert
Posted
@theAspiringDev1 no worries!
