Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 8 months ago

Bookmark landing page with React and Motion

react, vite, motion
P
Boris•4,150
@makogeboris
A solution to the Bookmark landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I’m thrilled to have completed my first React project! Excited to keep improving and explore more advanced concepts. Feedback and suggestions are greatly appreciated!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Descieux360•40
    @Descieux360
    Posted 6 months ago

    Very clean design

  • P
    Nikita Vologdin•710
    @NikitaVologdin
    Posted 7 months ago

    - Layout:

    • I am suggesting to increase with of the decoration elements to follow the design. But since you are using img tag to render svg from the figma it is impossible. So i suggest:
      1. use inline svg and with css control its width.
      2. or make a div and use border radiuses (this option you can checked in my work, it is still not perfect though). I believe this approach is more preferable due to less document size.
    • "get it on firefox button on hover needed to be transparent"
    • In the accordion component no bottom border for the last child.

    - Animations:

    1. Tabs section. Cool animation idea though, but should look more smooth. Know framer motion not easy, just highlighting for further discussion.
    • Animation glitch when start using tabs section for the first time.
    • In the same section distance between left viewport border and decoration element I think can be fixed by the
    1. Accordion works funny when expanding items. They like expand in opposite direction.
    2. Also I believe you can add animation for error status on the email input.

    - Responsiveness

    • Dialog menu can be scrolled to the overflow on x,y axis. I suggest use css:
        body:has(.dialog[open]) {
            overflow: hidden;
        }
    
    • Download items looks odd from 672px width of the viewport.

    - Performance

    • Suggest you to check you app in the lighthouse. Can be found in chrome dev tools. You can improve performance hosting fonts, optimising images and etc.

    Flawless work with the accessibility. Awesome layout implementation. Cool animation ideas. Very like your work. Thank you for reading.

    Best, Nikita

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub