Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Brand Apparel using HTML, CSS and JS

@NwosaEmeka

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback will be most welcomed, especially areas to improve on. I think the final product didn't do justice to the design :) :)

Community feedback

Shubham Sharmaโ€ข 855

@shubhamthedev

Posted

Hi, the design looks great in my opinion specially the way you nailed responsiveness is great even i wasn't able to do that on this project. Some suggestions that i would make:

  • The font sizes seem to be a little to small specially on bigger screens.

  • The hero image looks a tad bit thin in the final design.

  • The mobile version of the site has a blank space on the top for some reason and I'm not sure if it's my browsers fault or not, since i read the code and couldn't figure out where that space is coming from.

  • You should color font inside the input element to pink.

  • Lastly you should fix the accessibility issues which i wouldn't say much about because i make those mistakes myself.

Those were some of my suggestions. Keep working hard and Happy Coding ๐Ÿ‘จโ€๐Ÿ’ป.

2
Adarsh Pratapโ€ข 5,515

@adarshcodes

Posted

Hey! @NwosaEmeka, Great work on this solution๐Ÿ‘, consider the modification recommended by tomboynotes

1

@NwosaEmeka

Posted

Thanks a lot.. I will look at your suggestion and fix up. Thanks so much for the feedback

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord