Skip to content
Submitted almost 4 years ago

Built with React + Redux + Styled Components

Agata Liberska•4,075
@AgataLiberska
A solution to the Product feedback app challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I wanted to use this project to practise Redux with React. I feel like my file organisation isn't great (I went through a Udemy course and the Redux tutorial and kind of ended up with a mix of the two suggested systems which I'm not sure is the optimal way). The project was very challenging at some parts but I think I learnt quite a lot, and I'm planning to do another take of this challenge, this time with async operations. And of course, I am yet to write up a nice readme, please don't hate me for it. Anyway, any comments on functionalities, or the code are welcome. Thank you!

Code

Please log in to post a comment

Log in

Community feedback

  • Jay•695
    @Junjiequan

    Hello, Agata.

    I am currently also working on this challenge and I have to say this one is tough. You did really nice work on this solution.

    Here are some issues I have found:

    • Sort by button is slightly shifting on click

      Probably caused by border on focus. I would suggest to use box-shadow: 0 0 0 1px color to make the focus border effect

    • Scroll prevented?. not able to scroll content.

      I guess you did it on purpose to test something.

    • Textarea horizontal resizing breaks out

      I'd suggest either use resize:none or resize:vertical

    • The feedback title in product detail page or to say product commenting page should be unable to click or the link functionality should be prevented. Click the title multiple times causes Go Back button not working properly (have to click multiple times back to make it work).

      This is the issue from browser router. My solution was to simply set the title's pointer-events to none when it rendered inside the product commenting page.

    Hope you find this feedback helpful.

    I took some time to check your solution as you were the first person who gave me feedback on my early solution and I am always grateful for that :)

    Marked as helpful
  • Emmilie Estabillo•5,600
    @emestabillo

    Hey Agata, congrats on this project! Looking good and functions well. I’m viewing everything on mobile and the menu appears behind the comment cards. I’m also seeing a horizontal scroll, I’m not sure where it’s coming from since I’m ios only right now. Planning to take a look at the codebase tonight as I’m also eyeing this project and could take a few pointers from you lol. Great job!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord