Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

Built with React + Redux + Styled Components

Agata Liberska•4,075
@AgataLiberska
A solution to the Product feedback app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I wanted to use this project to practise Redux with React. I feel like my file organisation isn't great (I went through a Udemy course and the Redux tutorial and kind of ended up with a mix of the two suggested systems which I'm not sure is the optimal way). The project was very challenging at some parts but I think I learnt quite a lot, and I'm planning to do another take of this challenge, this time with async operations. And of course, I am yet to write up a nice readme, please don't hate me for it. Anyway, any comments on functionalities, or the code are welcome. Thank you!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jay•695
    @Junjiequan
    Posted almost 4 years ago

    Hello, Agata.

    I am currently also working on this challenge and I have to say this one is tough. You did really nice work on this solution.

    Here are some issues I have found:

    • Sort by button is slightly shifting on click

      Probably caused by border on focus. I would suggest to use box-shadow: 0 0 0 1px color to make the focus border effect

    • Scroll prevented?. not able to scroll content.

      I guess you did it on purpose to test something.

    • Textarea horizontal resizing breaks out

      I'd suggest either use resize:none or resize:vertical

    • The feedback title in product detail page or to say product commenting page should be unable to click or the link functionality should be prevented. Click the title multiple times causes Go Back button not working properly (have to click multiple times back to make it work).

      This is the issue from browser router. My solution was to simply set the title's pointer-events to none when it rendered inside the product commenting page.

    Hope you find this feedback helpful.

    I took some time to check your solution as you were the first person who gave me feedback on my early solution and I am always grateful for that :)

    Marked as helpful
  • Emmilie Estabillo•5,600
    @emestabillo
    Posted almost 4 years ago

    Hey Agata, congrats on this project! Looking good and functions well. I’m viewing everything on mobile and the menu appears behind the comment cards. I’m also seeing a horizontal scroll, I’m not sure where it’s coming from since I’m ios only right now. Planning to take a look at the codebase tonight as I’m also eyeing this project and could take a few pointers from you lol. Great job!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub