Hi Daniel Hameed
I will add more to what have been said above.
- the html for the theme switcher will need some revision, it is ideal to use radio buttons in a fieldset. Radio buttons allow one selection from a group which is exactly what we need. You have used p elements and div elements which are not accessible to assistive technology users and at the same time there is repetition of interaction where both the
p
anddivs
all have click events for the same purpose. - add focus state that can assist keyboard users know where the current focus is when tabbing on a keyboard.
- let your calculator have maximum number that can be entered , we can not have a calculator that takes any number that the user desires.
- a calculator should guard against some of the following , try it in your calculator
9++++++
9++++++*******----
4.......3.36...
- try the following calculation
0.1+0.2
I concur with @elaineleung on the need to do challenges of a lower level than this one . This calculator has some twist and turns that needs to be carefully implemented . I would suggest the tip calculator for now
Happy coding
Marked as helpful
@HDanielO
Posted
@ChamuMutezva Thank you so much π€²πΎ. This challenge has shown me I still have a lot of learning to do