@GiDDeRo
Posted
Nice Solution
- I'll say learn to use semantic tags
- Make h4 text more bold.
Happy Coding!
Marked as helpful
Looking to hire developers?
@GiDDeRo
Posted
Nice Solution
Happy Coding!
Marked as helpful
@correlucas
Posted
πΎHi @giovannirizzolo, congratulations on your solution!π Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw youβre on the right track. Iβve few suggestions for you that you can consider adding to your code:
<main>
instead of a simple <div>
this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main>
block and that <div>
doesn't have any semantic meaning.<h4>
containing the main title with <h1>
note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.margin: 20px
to avoid the card touching the screen edges while it scales down.rem
or em
instead of px
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
βοΈ I hope this helps you and happy coding!
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord