Hello, Benjo! 👋
Congrats on finishing another challenge! 🎉 Your solution looks very good and also responds well. Here's my few tips:
- Change the
alt
attributes for the.logo
,.desktop__computer--img
,.mobile__image
,.features__img
images, as they don't add any extra context for screen reader users. Since your images are decorative youralt
text should be provided empty (alt="") so that they can be ignored by assistive technologies. - Add
:focus
pseudo class to interactive elements like anchors, buttons etc. Useoutline
property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default:focus
pseudo class withoutline
property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles. - Instead of using
<div>
elements to wrapping your.sponsors__item
you should use anchor element<a>
because this element is going to transfer user somwhere.
Good luck with that, have fun coding! 💪
Marked as helpful
@benjoquilario
Posted
@tediko sorry for the late reply, thank you for tips, I will change It now :D
@benjoquilario
Posted
@tediko thank you for the tips if you have a extra time, check it again.
- I change the alt attributes.
- I already add the outline with none.
- I already change the <div> with <a>
thanks for the tips I learned a lot especially the 1 and 3 tips you mentioned.