clipboard landing page (HTML CSS/SASS

Community feedback

• 

  tediko•6,700

  @tediko

  Posted about 4 years ago

  Hello, Benjo! 👋

  Congrats on finishing another challenge! 🎉 Your solution looks very good and also responds well. Here's my few tips:

  • Change the alt attributes for the .logo, .desktop__computer--img, .mobile__image, .features__img images, as they don't add any extra context for screen reader users. Since your images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • Instead of using <div> elements to wrapping your .sponsors__item you should use anchor element <a> because this element is going to transfer user somwhere.

  Good luck with that, have fun coding! 💪

  12

  Marked as helpful
• 

  P

  Patrick•14,265

  @palgramming

  Posted about 4 years ago

  Looks really good all I see is you are missing your :hover state on your social icons

  13

  Marked as helpful