P
Matt Studdert• 13,611
@mattstuddert
Posted
Awesome work, Saurav! Your solution looks great! Here are a few small pointers after taking a look at your code:
- Your HTML looks great. The only thing I'd add would be more semantic HTML5 elements like
header
andsection
. Also, a quick heads up that thefooter
is currently outside of thebody
, which shouldn't be the case. - In your CSS you've got this media query:
@media (min-width: 320px) and (max-width: 480px)
. You could just remove the(min-width: 320px)
condition as that would take care of everything below480px
. - Nesting is a really useful feature of Sass, but be careful not to overuse it as it can lead to overly specific CSS selectors. For example, in your generated CSS you've got a selector of
footer .footer_content .footer_links .links
which could just be.links
.
I hope these tips help. Keep up the great work!
1
Saurav Chamoli• 370
@sauravchamoli17
Posted
@mattstuddert Thank you very much Matt! I was waiting for your review on the solution and your tips always helps me to become a better developer!
0
P
Matt Studdert• 13,611
@mattstuddert
Posted
@sauravchamoli17 you’re welcome!
0