Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

Clipboard Page ussing Flexblox

Marialba Córdova•60
@Marialba16
A solution to the Clipboard landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi guys! I would like to know your opinion regarding my code, I would appreciate it very much since I am new to this.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted almost 4 years ago

    Hey, great work on this one. The layout in desktop is very good, however the responsiveness could be a lot better, there are sections which are being hidden, contents being squeezed and some overlapping one another. On mobile state however, it looks good.

    Some suggestions would be:

    • The alt text for the website logo in the header could have used only alt="clipboard". Avoid adding words that relates to "graphic" like "image, picture, icon, logo", assistive tech will handle those for you.
    • The alt text for the different company should use their names as the alt value, like alt="google" on the google img.
    • On the footer you are missing the background-color like on the original, adding that would be really great so that there will be some sort of color divider and not just all pure white.
    • footer website logo could use as well alt="clipboard".
    • The links in the footer section are missing their visual indicator in the :focus-visible state. Either having a outline border or box-shadow would be really great.
    • The links as well in the footer could be wrapped inside a ul element, so that screen reader users will know how many links there, since screen reader will announce how many items are there inside a list.
    • The social media links should be wrapped inside a tag since those are links, better using a tag. They could also be wrapped inside a ul element. Adding as well the aria-label for each a tag that will wrap them. An aria-label is a piece of text that screen reader will say if they encounter that element. Since there are no text in the social media link right, a screen reader can't say anything, but when an aria-label is associated on them, they will say that text. Example, the a tag that will wrap the facebook icon would have:
    <a aria-label="facebook">
      icon of the facebook
    </a>
    

    This will make your website more accessible.

    • Lastly, try to solve the responsive issue that has been state above. Always inspect you layout in dev tools, change the screen size, test if the elements are correct and in proper place.

    Aside from those, this is really great. The structuring is fine, just for those links right.

    Marked as helpful
  • Chamu•13,860
    @ChamuMutezva
    Posted almost 4 years ago

    The narration by @Raymart Pamplona is awesome , use dev tools and check your site between 451px and 800px . So far so good, just one more push.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub