Clock app challenge with React and SCSS

Community feedback

• 

  

  ApplePieGiraffe•30,525

  @ApplePieGiraffe

  Posted over 4 years ago

  Hey, Guy Ezra! 👋

  Nice to see you complete another challenge! Good work on this one! 👍

  In addition to emestabillo's helpful feedback, I suggest adding the background image as a CSS background image and setting background-size to cover so that the image fills the entire screen but is cropped and doesn't distort when the page is resized. 😉

  Keep coding (and happy coding, too)! 😁

  12
• 

  

  Emmilie Estabillo•5,580

  @emestabillo

  Posted over 4 years ago

  Hey Guy, works well! Just going to comment on the design:

  • The refresh button keeps moving depending on the length of the quote it retrieves. The user constantly needs to locate it for subsequent quotes.

  • Font styles (esp. sizing) could be improved

  • .more-info is not using its mobile design on smaller widths

  • For larger screens, the component seem to stretch along with the change of widths. I would try applying a max-width to it

  • project could use more semantic html as opposed to divs for the most part

  • Lastly, the clock is not updating (although this is not included in the list of expected behavior)

  Hope this helps :-)

  11