Hey, Emmilie Estabillo! 👋
It's great to see you complete another challenge! I think you've done a great job on this one! 👍
Your solution scales up/down nicely and all of the interactive elements work great! I especially like the dotted outline you added around the clickable elements of the page when they are tabbed to—I think it fits the feel of the rest of the design quite well. 👏
textContent is a safer option since the browser won't parse whatever is added into the HTML as actual HTML—just text. Can't decide between
textContent? This StackOverflow question I came across yesterday (or the day before—I've done so much CSS positioning in the past few days, I can't remember, LOL) might help. 😃
Personally, I think what you've done with
<h2> tags is fine, since the most important reason to use the
<h1> tag is probably for like SEO and accessibility (both of which are taken care of in your solution)... so there shouldn't be any problem with the
<h2> tags being larger or visible. I think. 😉
As for making your HTML more accessible—I'm no expert, but perhaps you could look into the
aria-expanded attributes to see if they'll help screen readers better identify the function of the "More" button (here's a page from W3 I found the other day that explains those two attributes). IDK, I'm wary of adding WAI-ARIA stuff on a whim and you're HTML may be fine as is! 😅
I'm not very familiar with APIs and advanced JS yet, so I'll shy away from commenting on some of the other questions you had. 🙃
Well, keep coding, of course (and happy coding, too)! 😁
@ApplePieGiraffe Hey APG! Thanks so much for all your insight! It's really helpful to know what other devs think.
I actually might've come across that SO post while doing this project lol. I ended up using
textContent for the same reason you mentioned.
I'll look into ARIA, thanks. There's quite a bit to remember about accessibility, sometimes I get lost in all the rules.
Thanks! I'll definitely focus more on JS! 😉