P
Øystein Håberg• 8,080
@Islandstone89
Posted
Hi, good job on this challenge. Just a few things to take note of:
HTML:
- "Learn More" would navigate to another page, hence it should be a link, not a button.
CSS:
-
On
main,height:100vhshould bemin-height: 100vh. -
It's good practice to include a CSS Reset at the top.
-
Font-size must never be in px. Use rem, or em like you have done elsewhere.
Marked as helpful
2
MarcoDV• 230
@MarcoDV47
Posted
@Islandstone89 Thanks for the feedback! I really appreciated you posting the articles and i learned a LOT from them. I can say i learned at least 3 very important things. I don't know yet if that's good or bad, but i create my CSS reset on a separate file. Thanks again :)
1
