@mattstuddert
Posted
Hey Vaibhav, nice work on this challenge. As far as abstraction goes, you could definitely re-write your CSS slightly to make some more reusable classes. For example, for the .bg-*
classes you're often repeating background-size: contain; background-repeat: no-repeat; height: 10rem;
. For these common styles, you could just create a single class and add that class to the necessary elements.
Also, using an empty div
for the background images is fine. Another way, which I prefer, would be to use a pseudo-element, like ::before
to add the curve detail. This leads to less HTML code, which is cleaner.
Let me know if you have any questions. Keep up the great work!
@Vaibhav-chandak
Posted
@mattstuddert Ok I will make the changes and will take care of it in future. Thanks for the feedback.