Hello, Alex! 👋
Congrats on finishing another challenge! 🎉 Your solution looks very good and also responds well. Here's my few tips:
- After opening a modal with my keyboard the focus isn't in modal and I can't select modal options right away. Take a look at this great @brasspetals solution (link). She implemented focus trap in her project to - in short - prevent focus to go outside the modal once the modal is opened.
- Change the
alt
attributes for the mastercraft logo, as it doesn't add any extra context for screen reader users. Since your image is decorative youralt
text should be provided empty (alt="") so that they can be ignored by assistive technologies.
Good luck with that, have fun coding! 💪
Marked as helpful
@p-alex
Posted
Hey @tediko! Thank you so much for the tips. I tried to implement focus trap myself but didn't work very well. I'll take a look at @brasspetals solution and see if i can fix it.