Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

CSS and HTML

Yewande Adeyemi•110
@Wandesanguine
A solution to the Huddle landing page with a single introductory section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


My code is very okay for mobile view cause I coded foe mobile first. I really think there is a problem with my code. I just know something is hindering my media query, It's not even working at all. I hope someone can help me out with this. Happy coding everyone.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Elaine•11,360
    @elaineleung
    Posted about 3 years ago

    Hi Yewande, I think what you can try is to use grid for the desktop view, but before setting that up, I would change the max-height: 100vh on your body selector to min-height:100vh; personally I probably wouldn't use max-height anywhere on this site and would just remove them all. I also suggest not using the position absolute for the logo, as that would prevent it from being movable in relation to the rest of the containers.

    In your code, try adding these lines first:

    body {
      display: flex;
      flex-direction: column;
      min-height: 100vh;
    }
    .container {
      flex: 1;
      background-size: cover;
    // remove max-width and margin
    }
    .huddle {
    // remove position:absolute
      text-align: left;
    }
    

    I see that you have a max-width on the img right now; that can be changed to something bigger in the desktop view when you write your media query, which along with using display:grid for the layout would look something like this:

    @media (min-width: 980px) {
        .container {
            display:grid;
            grid-template-areas: 
           "huddle huddle"
           "image text";
            gap: 1rem;
        }    
        .main-image {
           grid-area: image;      
        }
        .main-image img {
           max-width: 600px;
        }
        .huddle {
            grid-area: huddle;
        }
        .text {
            grid-area: text;
        }
    }
    

    I suggest experimenting a bit more with flexbox and grid, and you may discover that you won't need to use things like max-width and position:absolute for positioning layouts like this one.

    Good luck!

    Marked as helpful
  • Account deletedPosted about 3 years ago

    Hello @Wandesanguine I saw your code and i think the easiest way to add responsivness from mobile to desktop is wrap the .main-image & .text in another <div> and create a Media query to style it like this :

    @media ( min-width:400px ){
    .image-text{
    display:flex;
    flex:direction; **it's the defaul value**
    align-items:center;
    justify-content: center; } }
    

    it should look like this https://prnt.sc/KJXfn9rep4Y7

    After this you could tweak the other stuff

    Feel free to contact if u got any problem or tweet it @me

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub