@ApplePieGiraffe
Posted
Hi there, Folarin Akinloye! π
Nice to see you complete another challenge! π Good work on this one! π Your solution looks good and responds up/down pretty well!
I'd like to suggest,
- Setting
text-align
tocenter
for the heading and the description text in the mobile layout of the site (as in the original design). - Like ctnance mentioned, adding the background images from the original design using CSS background images.
- The way you named your CSS classes looks pretty similar to BEM (just add an extra underscore between terms and you'll be following BEM, too). π
It's good to see you remembered to leave out the alt
text for the stars images (so that screen readers don't repeat themselves a whole lot). π
Keep coding (and happy coding, too)! π
@folathecoder
Posted
@ApplePieGiraffe Thank you for the feedback. You are sooooo awesome πππ!
- I will work on my "attention to detail"! I use a small screen to code, so switching between multiple tabs got me lazyπ€¦ββοΈ, but that's not a good excuse!
_ I was going for BEM, lol, but I totally missed an extra underscore. I will fix that in my subsequent challenges. π
Thank You!
@ApplePieGiraffe
Posted
@folathecoder
Haha, no problem! I often code on a smaller screen, too, and I also feel a little lazy when it comes to responsive design, sometimes. π The attention to detail is worth it, though, since it's like the icing on the cake to a good project! π
Have fun coding! π