@Shirajuki
Latest solutions
Latest comments
- @ctnance
Hi Shirajuki,
Great job on this project, especially considering your time restraints and this being your 2nd project!
My first impression is that you did a fantastic job matching your design to the original. I would only recommend adding some margin between the text in the "info" classes (inside the "infoWrapper").
I also find your use of the ::before & ::after selectors an interesting, but an effective choice for the background images within the body tag. I like how it turned out!
Happy Coding!
- Chris
- @Munegu@ctnance
Hi Munegu,
Great work on this challenge! Your HTML & SASS code looks very clean and well organized. For your first Frontend Mentor challenge, I'd say you hit a home run!
One small recommendation I can think of would be to add a box shadow around your card to fit the original design (if you'd like).
You could also play with margin/padding values to closer replicate the original design if you feel the need, but this isn't really necessary. I think you've done a fine job as is.
Happy Coding!
- Chris
Marked as helpful - @ctnance@ctnance
Thank you for taking the time to leave your feedback, Matt!
These are helpful pieces of advice and they all make perfect sense for best practices. I will update the code as soon as I get a moment.
Again, I appreciate your feedback. Happy coding! :)
- @folathecoder@ctnance
Hi Folarin, great job on this one!
I noticed you used several media queries for the same min-width; I'm not sure if this was intentional, but you could use only one for the same effect to trim down your code.
Also, don't forget you can add the background images as well with the background-image attribute.
Again, really good work--keep it up!
- @FaridJunior@ctnance
Hi Mohamed, great job on this one!
I would recommend cleaning up two HTML code snippets--line 46 reads "<spa class="close-icon">"; I figure you're wanting the span tag, which is an easy fix (just be sure to correct the closing tag as well).
Also, for your attribution div, the first <a> has the attribute rel="noreference". I'm not sure noreference is valid. Did you mean noreferrer?
Otherwise, I really like how your challenge turned out. It's very close to the original design!
- @KevinSalina@ctnance
Hi Kevin--really good job on this one!
Don't forget to give your email input a name attribute for referencing purposes (not necessarily needed for the challenge, but necessary for standard HTML code).
I saw you mentioned that you struggled with the footer; for the telephone and email icons, you could try putting your img and p tag inside of a span tag (you may need to play with the padding for proper orientation). Otherwise, just generally playing with your margins/padding should help in other cases.
Overall, you did a great job!
