@mattstuddert
Posted
Great work completing your first premium challenge, Christopher! You've done a brilliant job! It's nice to hear the challenge has changed your thinking as well. I'd love to hear more about what you learned!
Here are some thoughts after taking a look at your code:
- The
alt
text in various images could be improved to help with accessibility. For example, the logo has the alt text of "pod-logo". First off, I'd recommend not adding hyphens unless that's how you would write the text normally. Also, for logos, it's best to simply put the company name. So, in this case, it would be "Pod". The same goes for the podcast platform logos lower down. - You don't need the additional
label
for the submit input. Another way of doing it would be to use abutton
element instead ofinput
withtype="submit"
. - As the dotted pattern is purely decorative, I'd add the image using a pseudo-element and
background-image
in your CSS. This means you're not adding unnecessary HTML code. - Avoid using IDs as CSS selectors. They have high specificity and can't be reused on the page, so they're not suitable for styling. Instead, I'd recommend sticking to class, attribute, pseudo, and type selectors. Using these will help keep your CSS more maintainable.
I hope these tips help. Keep up the great work! 👍