@mattstuddert
Posted
Hi Hany, congratulations on submitting your first solution! Just a quick heads up that the preview link isn't working at the moment. You can update it by clicking the 3 vertical dots by the solution title and selecting "Edit Solution". That will make it easier for people to see what you've built.
I hope you enjoyed the challenge!
@mattstuddert
Posted
@Hany-soliman you're welcome! I've just had a look. Great work! It looks really good. I've got a couple of suggestions after checking out your code:
- In the design, the
h1is spread over two lines. So to get it looking that way you could adddisplay: block;to the.title-spanclass and remove thewidthfrom.title - You're currently only changing to the desktop layout at
1440px, whereas I'd say this could be done sooner. So have a bit of a play around with screen sizes to find the right breakpoint.
I hope these tips help. Keep up the great work!
@Hany-soliman
Posted
@mattstuddert Hi Matt, Thank you so much for your comment! Yes, I did enjoy the challenge a lot, and I'm already preparing for my next one. Regarding the Live Link, I've edited and now it should be working properly.
I will be looking forward to your feedback!
@Hany-soliman
Posted
@mattstuddert Sorry for the late reply! I never received a notification for your comment :/.
The tips helped! I've adjusted the h1 to be in one line and added the display block. I've also changed the breakpoint to be 1024px instead of 1440px.
Thanks again!
