Please log in to post a comment
Log in with GitHubCommunity feedback
- P@ecarlste
Great job using semantic HTML for <nav>, <section>, and <footer>. It was really easy to follow where the different parts of the layout were located.
I didn't find any issues with accessibility at a glance. I did run it through an accessibility checker which was recommending not using the <h1> and <h2> tags on line 63 and 226. It claimed these were in violation of WGAC 2.0 Level AA under success criteria 2.4.6 "Headings and Labels (AA)".
The layout looked great while resizing. There was one breakpoint when it switched to the smallest mobile size where the diagonal balance looked a tad off with the two buttons at the top of the first section, and right before that breakpoint the padding between the image and the text looked a bit off.
The code was very well organized and easy to read. I'm not sure on reusability since you were using HTML only so I don't think this really applies.
Unfortunately I can't comment on how your design might differ from the intended design since the side by side comparison is showing the qr-code component challenge rather than the emergeAI website challenge. Give how good the design looks I'd be surprised if it differed much from the design given.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord