Skip to content
Submitted almost 5 years ago

desktop first using grid with dark mode

Noxde•125
@Noxde
A solution to the Digital bank landing page challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Any kind of feedback is appreciated!

I'd appreciate feedback on the dark mode as well! Thanks

Code

Please log in to post a comment

Log in

Community feedback

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe

    Hey, nice job, Noxde! 👏

    Your solution looks good and is responsive! 👍

    I only suggest,

    • Perhaps doing something about the hero image on large screens (since currently, it overflows the body of the page and creates some blank space along the right side of the page) such as setting overflow-x of the body to hidden or moving the image closer to the center to the page and away from the edge.

    Also, if you're interested in clearing up those issues in your HTML report, I believe adding a <title> tag to your SVGs will get rid of the "Anchor element found with a valid href attribute, but no link content has been supplied." errors.

    Cheers!

    Keep coding (and happy coding, too)! 😁

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord