E-commerce-sneakers-website HTML CSS JS mobile-first

Community feedback

• 

  Devmor•470

  @devmor-j

  Posted about 3 years ago

  Hey, great job on completing this challenge. This is a tough one and takes a moderate amount of time to reach perfection.

  overall looks great and one thing I noticed with the cart logic is that user might manually enter a negative value in input element. This logic could cause some problems in the back-end (store or payment system). I suggest maybe wrapping that section inside a form element could be a good solution which enforce user to enter numbers above zero and prevents sending data without criteria met.

  Another thing which affects user experience is that hovering on navigation items (like men, about, ...) must exactly be on the text itself but it would be easier to select if hover effect appears just close enough.

  To be precise I mean you could add padding directly on ul instead of nav. I think converting nav padding style to margin would avoid css break due to refactor.

  Overall I really liked your solution and there are no critical issues in my opinion.

  Keep it up and happy coding :) good luck!

  11

  Marked as helpful
• 

  Kaung Zin Hein•720

  @K4UNG

  Posted about 3 years ago

  Hey! It looks good! Great job on the challenge. I like the little popup that appears after clicking the checkout button. Here are a few things I noticed:

  • When I add items to cart, instead of reseting the number of items, you should add onto the existing amount. Also when I add item with no amount selected, the modal becomes blank so you should also prevent users from adding 0 items if you decide to keep the current adding method without increasing the amount of items.
  • When I delete the items, the amount indicator doesn't disappear. If I had two items in cart, even if I deleted them, the indicator is there still displaying 2.
  • For the transitions, I think you should make them a little faster. It wouldn't matter too much here but, for bigger projects you should keep your transitions point on to not negatively affect the user experience. For me, I use somewhere around 200ms or less for general transitions.
  • Lastly for the cart modal, instead of moving it from outer screen when clicked, you could move upwards just a little and accompany it with a fade animation. That way you can have a more natural loading animation.

  Great work and Happy Coding!

  13

  Marked as helpful