@mattstuddert
Posted
Great to hear that you tried out a mobile-first workflow and found it easier, Alex! Many people find that it takes a few projects to get used to it, so it's awesome that you've noticed the benefits immediately.
You've done an awesome job. Here are a couple of pointers after taking a look at your code:
- You've currently got 2
h1
headings. I'd recommend only ever having one as having multiple can cause accessibility issues with the content hierarchy. In this project, I'd actually say that it's a single heading. So you could make the whole thing a singleh1
and then separate the lines using aspan
element for the different styles. - It's great to see you using Sass. As you start building more complex projects, be careful not to nest selectors unnecessarily. For example, in your generated CSS file you've got this selector
.container > .card-1
when it could simply be this.card-1
. Also, I'd try giving elements more meaningful class names than.card-1
,.card-2
, etc. As this is such a small project, it's not a big deal, but it's something to be aware of in future.
I hope this helps. Let me know if you've got any questions! 🙂
@AlexGanderton
Posted
@mattstuddert Thank you so much!
@mattstuddert
Posted
@AlexGanderton no problem! 🙂