Flex and grid solution with Swiper.js

Community feedback

• 

  Rohith Suresh•65

  @rohith-23-creator

  Posted over 3 years ago

  OMG. That's an incredible work. I learnt a lot 👍

  11
• 

  Alex Kim•1,325

  @alex-kim-dev

  Posted almost 5 years ago

  Hey Emmilie! That's a really fantastic work! Your solution is pretty accurate compared to the design. Also I like how you structured your SASS - very convenient and simple. I honestly don't know what can be improved, but here is a little hint on using media queries in sass. I noticed you often write @media screen and (min-width: 992px) {}. We can cut a little code here by defining mixins:

  // mdUp means for medium screens (992px) and higher
  @mixin mdUp {
    @media screen and (min-width: 992px) {
      @content;
    }
  }
  

  then we can use it like so:

  .class {
    padding: 1rem;
    @include mdUp {
      padding: 1.5rem;
    }
  }
  

  And that's it. Good luck and I'll see your next project!

  33
• 

  Kenny Fairris•100

  @kfairris

  Posted almost 5 years ago

  Wow that’s identical. Great job!

  21
• 

  Oliver Sagala•120

  @sagspot

  Posted over 4 years ago

  Goodness!! This is really identical.

  You find it easier to use CSS to toggle the mobile nav, I thought js makes it easier and cleaner.

  Otherwise, this is really cool stuff

  11
• 

  Seokjin Kim•25

  @SukJinKim

  Posted almost 5 years ago

  Wonderful🥳

  11