@rohith-23-creator
Posted
OMG. That's an incredible work. I learnt a lot 👍
@emestabillo
Posted
@rohith-23-creator Thanks so much Rohith! 🙏🏼
This was a true test in writing responsive code. Would appreciate your thoughts. Many thanks to my mentor @shahsilo for helping me get really close to the design!
@rohith-23-creator
Posted
OMG. That's an incredible work. I learnt a lot 👍
@emestabillo
Posted
@rohith-23-creator Thanks so much Rohith! 🙏🏼
@alex-kim-dev
Posted
Hey Emmilie! That's a really fantastic work! Your solution is pretty accurate compared to the design. Also I like how you structured your SASS - very convenient and simple. I honestly don't know what can be improved, but here is a little hint on using media queries in sass. I noticed you often write @media screen and (min-width: 992px) {}
. We can cut a little code here by defining mixins:
// mdUp means for medium screens (992px) and higher
@mixin mdUp {
@media screen and (min-width: 992px) {
@content;
}
}
then we can use it like so:
.class {
padding: 1rem;
@include mdUp {
padding: 1.5rem;
}
}
And that's it. Good luck and I'll see your next project!
@emestabillo
Posted
@Alex-K1m Hi Alex, I agree about the media queries, it’s quite repetitive. I’ll refactor the project. Thanks for the feedback! 🙂
@sagspot
Posted
@Alex-K1m I learnt something as well. Thanks Alex
@alex-kim-dev
Posted
@sagspot You're welcome!
@kfairris
Posted
Wow that’s identical. Great job!
@emestabillo
Posted
@kfairris Thank you!
@sagspot
Posted
Goodness!! This is really identical.
You find it easier to use CSS to toggle the mobile nav, I thought js makes it easier and cleaner.
Otherwise, this is really cool stuff
@emestabillo
Posted
@sagspot Thank you! You can use either methods, just make sure to check for accessibility :-)
@SukJinKim
Posted
Wonderful🥳
@emestabillo
Posted
@SukJinKim Thank you!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord